Thread: Mangos + YTDB + Scriptdev2 + Changelog

nice one and stickied

Mangos 8938 - 8953
Implement talent 50880 and ranks.
Fixed talent 49200 and ranks triggered spell for arcane school.
Make players and totems always immune to taunt.
Limit used energe as expected for spell 22568 and ranks.

Thanks also to Sarjuuk for code simplification.
Spells 20911 and 25899 stats bonus.
Add spell_chain data for 24604 and ranks.
Use DBC data for summon effect functionality.

Also some more local fixes:
* Alow multiply same type guardians req. for some spells.
* Apply spell duration mods to summons

Many summon spells must start work.

Great work qsa!

Thanks The_Game_Master for updaing patch to recent sources.
Update work triggered effect for 20271
Implement talent 57499.
Implement aura SPELL_AURA_MOD_DURATION_OF_MAGIC_EFFECTS (245)

Used in spell 6117 (5/6 ranks)
Not check victim at apply SPELL_AURA_MOD_SPELL_CRIT_CHANCE_SCHOOL
for ranged spells

In same way as for other cases. For consistance.
Implement proper support spell auras with maxstack > 1 and charges
> 0.

* Like auras expected to be proccessed in spell proc event code (not lost
charge at use in spellmods code).
Exist examples for like spells that affect value in spellmods but have
different expire requirements.
* Propertly work with stacked auras in spell proc event code
- remove only one auras from stack
- in case charges exist in same time not touch charges but return expire

(all really used auars with maxstack>1 and charges have 1 in one from
this values)
Implement talent 55198.
Remove trailing spaces
Fixed loading `locales_gossip_menu_option`.
Use default gossip menu options if no options exist for "top level"
menu.

Also not close gossip menu in cases where no action_menu_id is set.
Apply spell mutiplier to final damage for health calculation in
Spell::EffectHealthLeech.

Nice to see your back, x3

If you need any help, hit me up on MSN.

Mangos 8954 - 8975
Implement spells 65495 and 65386.
Check gossip_menu_option table for GOSSIP_OPTION_NONE and output
error if exist
Implement aura SPELL_AURA_ALLOW_ONLY_ABILITY.

(cherry picked from commit f4d1e05)
Implement talent 53754.
Inlcude 15407 and ranks damage in talent 15286 affect.
Implement talent 15318 and ranks and move talent 44745 and ranks
code.
fix crash introduced with 8805

or actualy i didn't introduce a new crash there.. the old crash
just changed a bit..
after we force the player to logout without valid mapcoords the player
wasn't in
world anymore and through that Getplayer()->GetMap()->RemoveFromWorld()
caused a crash..

i changed now the error handling inside farteleport there.. instead of
forcing
a logout without saving, i just port him to his homebind
which will be much nicer

(minor cleanup with the other homebind teleportation.. we don't need to
check
for the error there.. homebind realy should be a valid coord)
Prevent crash in Aura::HandleAddModifier for far group member
Check player class instead of just active pet for gossip stable
option
Make bindpoint field private and add required functions for use.
Return in TeleportToHomebind return result from TeleportTo
Implement `quit` command for close RA connection.
Restore full stack bufs from talent 51528 and ranks using unique
aura type.
Fixed division by zero in Unit::CalcAbsorbResist.

This also fix spell 31662 work.
Implement gossip menu options for GameObject
Ignore in stacking check pure dummy spells.

One more hacks to SpellMgr::IsNoStackSpellDueToSpell
This fix for example 53601 with 20911 stacking.
Implement CONDITION_AREA_FLAG

Value1 is for "include flag", Value2 for "not include flag"
Correct mangos.sql after changes to creature_template in rev 8923
Some hacks to our hackish IsPositiveEffect function.

In attempt improve positive spells detection.
Clarify ICON_POI_* changes from 2.4.3 in comment.
Increase z limit for at transport coordinates for bettr support big
height lifts.
Spell 34914 and ranks will deals damage at dispel.

(cherry-picked from commit 6ff5b6a)

Mangos 8976 - 8993
Implement CONDITION_RACE_CLASS

Condition has independent value1 (race mask) and value2 (class mask)
fields and can be used with one or both.
Not send npcflag stablemaster to non-hunter player

Also check for player class vs stablemaster flag in
GetNPCIfCanInteractWith()
Fix wrongly apply weapon damage mods to broken weapon.
Remove unexpected added lines in prev. commit.
Avvoid apply spell bonuses to glyph 42408 heal amount.
Re-apply sql update from [8211] that not included in mangos.sql in
past.
Prevent infinity recusion at repally auras at sepllmod change.

Passive auras (in different area auras) not affected by another group
member spellmods.
In different from owned unit case.
Implement item 42988 buf expire effect.
Fixed max channaled spell distance check at aura update.

Radius for target applied chanmaled auras around affect, not for caster
diatance check.
So use spell range and _only_ for explicit pointed channled target for
spell.
Remove morph from spells including aura
SPELL_AURA_MOD_PACIFY_SILENCE

This fix at damage transformation remove for spell 51514/47585 and ranks.

Thanks to KAPATEJIb for prepare compatible version for current sources.
Implement resilience on periodic crits
Allow swap spell and command/reaction in pet action bar.

* Also prevent command/action drop from action bar
* Pet action bar will recetn at this revision use single time for all
pets.
Overwrite default wrong class family mask for spell 53817.
Clean up parts of WaypointMovementGen code for better readability
Correctly return DEFAULT_GOSSIP_MESSAGE and never 0 as gossipTextId


Fixes problem with summoned and gossip and where no textId is defined in
database
Merge 2 switch in Unit::HandleProcTriggerSpell
Fixed spell proc data for

* 19184 and ranks
* 53290 and ranks
* 34506 and ranks
* 35100 and ranks
* 46913 and ranks
* 51521 and ranks (use cooldown for prevent triggred spells proccessing)
* also 34457, 20784
Fix sql update for prev. commit.
Fixed spell family mask 53817 one more time.



Added Mangos SQL updade

Implemented Slad'Ran encounter in Gun'Drak.

Snake Wrap work needs research.


Mangos 8994 - 9007
Re-implement remove auras from channeled target

* Old way have problem with auras that have last tick avent at one from
caster/target:
depndent from auras update order in caster/target pair ti can wrongly
not triggered.
* Fxied possible problem with remove same spell non-caster auras at
target/caster at spell cast cancel
* Also fix memory lost in old deleted auras cleanup.
Overwrite wrong proc flags for glyph 43539 triggering.
Implement 2 items effect from itemsets 803/-33
Implement SUMMON_PROP_TYPE_REPAIR_BOT(12) support

Used only for item 49040 summon. Need DB support for proper work summoned
creature.
Allow pet guid to have gossip options like creature guid.
Make creature wild summoned by item 49040

This make it usable by other players, not only owner.
Also sort summon types by value in switch.
Reset time in more proper way.
Add internal cooldown for for item 42987 effect.
Make 8923_01_mangos_gossip.sql more propertly work

if rename target table exist by some reason.
Revert "[9000] Reset time in more proper way."

This reverts commit 8e8f7710e8baf29196256c6e0afcce1b7d3f3671.

Main reason: unexpected work in debug with breakpoints.
Also have other reports with strange effects.
Drop dead code case
Add internal cooldown for item 40373 effect.

Thanks to Splinter for cleanup query.
Trailing whitespace cleaning

Sorry for a (bit) delayed commit.
Set internal cooldowns for trinkets and some other items/spells.

Including items: 27683, 28418, 30619, 30626, 43134, 38579, 38212, 40767,
37559, 40865, 38071, 38072, 43462, 43470, 43573, 43829,
28190, 49076, 40682, 28034, 37220, 37390, 37064, 44308,
37660, 37264, 39229, 37657, 40258, 40382, 41385, 43838.

Also included data prepared by co-authors: Sephiroth1983, nos4r2zod,
Sarjuuk, oc_redfox, Alez.


Added Mangos SQL update

YTDB
+ All fixes from the forum and editing of bug reports (see "adopted patches")
+ Settlement
+ Scripts quests
+ Gossip-menu mobs
+ Editing DPP type = 2 under the "gossipy"
+ Adjustment "fishing_loot_template"
+ Adjustment "skinning_loot_template"
+ Adjustment "prospecting_loot_template"
+ Adjustment "disenchant_loot_template"
+ A complete rewrite of loot all bosses Crypt Arkavona
+ Handled 235 caches (about 2x gigs инфы) (3.2.2a), probably the last



Mangos 9008 - 9020
modelids for shapeshifts from dbc

this will correct some modelids:
form old model, new model
FORM_TRAVEL: 632 --> 918 (now a bit smaller)
FORM_GHOUL: 10045 --> 25527 (whisp --> ghoul)
FORM_CREATUREBEAR: 902 --> 2281 (old brown horse -> bear)

implement shapeshift for spell 24347

this commit also
fix the errormessages with: "Race %u not found in DBC: wrong DBC files"
which were triggered from this code
and will fix the modelid for creature 2038
since it's also using a shapeshift aura and only got the horde-modelid

+ some new entries in ShapeshiftForm-enum
+ some research for the shapeshift.dbc
More fixes in pet action bar buttons swap.
Implement realmd support realms for different client versions

* Supported 1.12.1, 1.12.2, 2.4.3, 3.2.2a in same time as relams in same
realmlist
* mangosd by self check correct for it client build and reject all
incorrect cases
* realmd know from mangosd what builds supported each realm and
if realm not support it then in relamlist for specific client this relam
show as offline.
Not need any manual settings for this.
Drop unused enum.
fix crash when achievement is completed and player isn't in world

also don't divide money loot for players who are not inside the
same map..
and player shouldn't be able to reclaim his corpse if it isn't in same map


and some other related cleanups
shapeshift spells

some shapeshift forms will give the player spells
so we need to tell the server that the player has those new
spells else he can't cast them since the server is thinking the player is
cheating

ps forms with spells:
FORM_GHOUL
FORM_THARONJA_SKELETON
FORM_TEST_OF_STRENGTH
FORM_BLB_PLAYER
FORM_TEST
FORM_ZOMBIE

--
so this mostly won't affect any ingame experience.. but good to have this
feature anyway..

also changed errormessage if player has no reagents for spell..
thx to nofantasy
Fixed unexpected error output for "unused" `db_script_string`.

When it reallt used in `gossip_scripts`.
Fixed spell 34914 ranks dispel damage and spell 29722 and ranks
bonus damage.

In both cases not expected additional spell damage bonus apply.
Add missing value for recently aded field in `realmd.sql
Fix typo in GO gossipID check for type 10
Implement aditional form specific bonus for 16857.

SQL data prepered by MrLama.
Add/update some hidden threat values for warrior/druid spells.
Re-implement 1680 (and triggred spell for 46924) in less hack way.