Thread: Mangos + YTDB + Scriptdev2 + Changelog

Long time no updates.

Code:

Mangos 9903 - 9972
Fixed build problem at *nix.
Add new config option for wait mode at startup error.

Note: it not applied to crashes and shutdowns after mangosd/relamd startup 
completed.
You can continue without delay (as now) and fast exist, or wait <Enter>, or some 
secs
for continue. Last can be helpful for see for example not applied sql update 
revision
data and etc.
Correct SMSG_INSTANCE_DIFFICULTY structure (fixes raid difficulty 
display).
More user friendly output at DB version check fail.
 Make comment really proccessed by doc generator.
Add missing break. Not affect current code work.
Prevent SQL injection in equipment sets code.

Author of original verison: Machiavelli
Implement expected from 3.2.x time limit for BattleGroundWS.

With updates and fixes from zergtmn.
 Check script using and existance at `creature_movement_scripts` load.
Partly revert [9911] :/
Fix TARGET_SCRIPT searcher and also look for objects that are Pet*

Pet (guardian, mini-pet) may also be the target of TARGET_SCRIPT, and are not 
considered a grid object.

 Add script effect of spell 51864, 51889 and 51910

In addition, dummy effect of spell 51866 and 51872 and dummy aura effect of 
spell 51870.
Dummy effect of 51866 might need additional work (see comments).

Code expect additional spell cast by AI (summon dummy at death of related quest 
target creatures).
Clarify game_event field values and fix typos.

Thanks to BrightStone for pointing to ;)
Fixed  .account onlinelist work.
Fixes in loot roll timer work and related cleanups.

* Changes include (in fact as part cleanup) fix got NeedBeforeGreed locked item 
after expire roll timer
  suggested by somedruid@mangos.lighthouseapp.com.
* Added cancel rolling at creatuer corpse remove.
* For NeedBeforeGreed and GroupLoot sued common code for prepare item roll.
Fixed player's tapped creature loot access by group in diff cases

* If player tap creature in group and leave then group will have access to 
creature loot if not disbanded
* If player tap creature and after join to group then creature loot will 
accesable only by player
* Also RewardPlayerAndGroupAtKill divided to simgle player and group reward 
versions used for group tap
  and single player tap cases.
Output player name in ObjectGuid player output string.
Restore group rewarding at player kill.
In case player who tap creature in group leave group it must anyway 
rewarded with group.
Rename BG_WS_UNK1 -> BG_WS_TIME_ENABLED
Fixed typo in prev commit.
Implement .server log filter and .server log level comamnds.

* .server log filter comamnd let temporary (until config reload or restart)
  set log filters state. Or look at filters state.
* .server log level renamed from .server set loglevel but now let look at log 
level also.
Add more log filters

* damage - different direct damage calculation tracing
* combat - combat state updates, roll attack result and etc
* spell_cast - spell cast progress and aura apply
Typos in Unit::DealDamageMods

Can be source very strange damage/absorb and any near stored/calculated in 
memory values. and crashes also.
Support new raid allowed quest types.
Fix build...
Move apply spell coeffs and level penalties code to new function.

* No reson have 6 copies near to exactly same code.

* This fix problem with apply attack power bonus in some case.
  Thanks to Wowka321 for find and reseach problem.
Move enum QuestTypes to QuestDef.h where it only used.

This is also fix build at GCC
After 3.2.0 expected AllowTwoSide.Accounts = 1 for any realm type by 
default.
Change AllowTwoSide.Accounts default in code also.

And update config version.

Also note: it not has been propertly updated in prev. time
when config version in .conf.in changed. It must be sync changed in
*.conf.in and in SystemConfig.h.in
Call DealDamageMods for leech DoTs damage
Skinning related fixes

* Show skinning tooltip only after creature loot
  (when creature can be explcitly skinned).
* Allow reopen skinning loot if still have not looted items.
ACE realmd, thanks to Zor and Vladimir for windows.
 Remove sockets library from UNIX build
Added copyright notice.
Correct premature call of TalkedToCreature.

Only use TalkedToCreature when gossip does not have any following sub menu (and 
of course when the prepared npc options does not include any gossip)
Sockets library use finally dropped

Specially thanks to Derex for make this possible! :)
Fix typo in AuthSocket.cpp
Add additional check for UNIT_NPC_FLAG_GOSSIP before using 
TalkedToCreature
Output ACE version at realmd start.
Add a small delay for npc despawn related to spell 51840

This will solve problem with summoned GO that does not appear before later, but 
does not solve problem with visual effects (which is a generic problem with many 
spells).
Implement spell 633 and ranks self casting restrictions in 3.3.x
Update mangos_spell_check.sql

* Add all data from Spell.cpp
* Add missing data from recent commist for added parts of SpellEffect.cpp
More skinning fixes.

* Restore work with money loot.
* Old code sometime generate empty loot windows for normal loot and sometime 
skip its.
  Code changed to be more consistent. Added new option Corpse.EmptyLootShow that 
  control
  show empty normal loot window in some cases enabled by default:
   - if creature expected to be lootable but loot generated empty by some 
   reasons.
   - if creature can be skinnable
  If option disabled thne code attempt avoid empty normal loot windows for empty 
  cases.
* Possible fixed case instant despawn non-skinable creature after normal loot 
complete.
Remove a few not needed checks in spell script effect
Add target for TARGET_DUELVSPLAYER_COORDINATES only if not provided by 
another way.

This fix for exmple unexpected empry heal if targeted by spell 48438 and ranks.
Fixed crash at .gobject turn command (at *nix at least)
Fixed bug with raid subgroup size update at move member to another.

Also some code cleanups
Allow update subgroup in raid for offline players.

Also prevent crash and wrong subgroup number send from client.
Remove two not needed cast to Creature* and make code more safe
Lost socket.vcxproj referecne in VS projects.

Thanks to j4r0d for catch this.
Prevent negetive proc events from possitive effects of negative spells.

Some negative spells have positive effects with targets not affected by negative 
effects of spell.
For example spell 45524 cast negative effecst to target and possitive effect to 
caster self.
For like possitive only target of negetive spell will not triggered negative 
proc events.
In last cases will avoid triggering glyph 43537 at caster at spell 43537 cast.
Spell 45524 expected apply debuf 55095 to target at cast.
Alow sell item for money and extanded coset without momey in same time.

npc_vendor.ExtandedCost can be negative now that meaning:
price excluded default item BuyPrice and use only abs(ExtandedCost) items).
For example expected used for item 36908.
Implement item 34753, 43015, 43478, 43480, 46887.
Fixed resent radnom problem with looting related to skinning code 
changes.

Thanks to boxa for help in research problem.
Implement glyph 43390.

Chance unknown and seelcted by more recent comments.
Restore work talent 18213 and ranks.

Thanks also to insider42 for updating.
Modify way 4x damage bonus claculated for spell 1120 and ranks.

* Now apply 4x bonus dependent from target health in time spell cast,
  not from current health in tick.
* 4x bonus applied to own spell damage value, not to total taken damage.
Implement per-tick chance for shard for spell 1120 and ranks.
Implement Treshold in Masterloot.
Fixed triggering of spell 55095 by 45524.

(based on insider42's repo commit 90de00d)

It include reverts commit ca99760e884d82219fff63ecf5f2ca87b02b5924
with less clean implemetation.

[patch 155] Fixed triggering of spell 55095 by 45524. Patch provided by me

(based on commit 90de00d)
Add CharacterDatabaseCleaner to VS2010 filters.
Fix 16164 proc conditions
Allow have reserved entries with empty names in log filters table.
Additional check for HandleAutoBankItemOpcode.
Fixed array free in vmap code
Typo in BattleGroundQueue::AddGroup arg name
Move CharacterDatabaseCleaner.* to Tools group as for VS100 done.


YTDB 323

+ All fixes from forum;
+ fix spawn;
+ quest scripts;
+ mob's gossip menues;
+ new templates from WDB
+ update fields "*_template" by WDB
+ filling table "creature_movement_scripts"
+ processed 221 caches (3.3.3a)

Code:

Mangos 9973 - 9999
Fixed selection BG map difficulty.

Thanks to insider42 for help in research problem.
Restore raid functionality broken after one from 3.3.x switches.

* Fixed typo in raid converting code that triggering raid disband at server 
restart.
* Fixed current subgroup show for character and update group memebers data at 
move its
  in diff subgroups.
Use special function for honored/xp kill check
Fixed typo in recently added group enums.
Update talent 16180 and ranks work.
Add explicit AP damage bonus for spells 55095, 55095.

Original patch provided johonson.
Update max cooldown length req. for spell casting at arena.
Remove target guid in spell with TARGET_FLAG_DEST_LOCATION

Corrects spell animations and visual going in weird directions for these kind of 
spells
For non-player at "offline" delete hostile references.

This must fix porblem with call message broadcast from unit destructor.
Group out of range member must based at client existances.
Also move empty mask check from build function to caller.
Leave at AFK applied only to battlegrounds (not arena)
Also restore build...
Implement item 43214 work.

* Original version suggested by timmit.
* Required DB support for target requirement.
Send SMSG_CORPSE_NOT_IN_INSTANCE if player in ghost form tries to enter an 
instance without player's corpse.
Talent 51459 and ranks affect only melee auto-attacks.
Restore work talent 12311 and ranks.

Thanks to insider42 for prepare patch for mangos.
Add correct spell chain data for 61024 and 61316.
Use unix styoe line ends in soem files
Use more correct data for prev. sql update.
Next step in fix SMSG_GROUP_LIST structure.

Now assistant/main tank/main assistant show properly
for viewer character also.

Thanks to insider42 for posting patch in Under review section.
Fixed MSG_PARTY_ASSIGNMENT processing.
Limit spell 50988, 59870 targets amounts to expected.
Fixed a bug/typo that prevent to summon a special flying mount.
Move GridMap class (and related structs/enums) to separate cpp/h.

Also rename some structs/enums and fix some code style.
Remove grid state debugging code and move state machine to MapManager.
Some changes in HashMapHolder.

* Use ACE_RW_Thread_Mutex, since there's much more reading than writing.
* Use read lock in Find(), and write lock in Insert() and Remove().
* Correctly lock the hashmap on outside calls.
Fix *nix build.
Remove a piece of trailing whitespace.

YTDB 324

+ All fixes from forum;
+ fix spawn;
+ quest scripts;
+ mob's gossip menues;
+ new templates from WDB
+ update fields "*_template" by WDB
+ processed 245 caches (3.3.3a)

Mangos 10000 - 10011

Code:

Redundent empty line.
Rename current version sql updates (0.16/root dir) to 5 digits format 
rev.

* order guards not affected in sql updates so this not affect sql guards work.
* TO DEVS: in next sql update commit please check carefully generated by git_is 
-s
  sql guards for correctness
Fixed map loading .map build checks.

Bug exist long time before recent code moves.
But it not affect in cases proper .map files.
Fixed unix* install.

I forgot update sql updatenames in Makefile.am after its rename.
Add script effect of spell 43365, 50217, 50218 and 50238.
Add script effect of spell 41055 and 45206.
Fixed typo in mangos.sql
Fix wrongly initialized value
Fix sqls
Fix realmd to accept more than 64 connections on windows.
Use schoolmask enum in struct SpellNonMeleeDamage, some indents fix.
Check redundent procFlags value in `spell_proc_event`.

All .NetFramework versions has been added

Added a program for x86, this one must work if .NetFramework didn't work for you.

nice , keep it up mate

Mangos 10012 - 10025

Code:

Fix charges taking for 16246
Implement CONDITION_QUESTTARGET

For cases when loot dependent from some quest objective complete state.
Revert "[10013] Implement CONDITION_QUESTTARGET"

This reverts commit 4e460746c0947f6cfc1f1150a8eb90257819eae2.
More redundant data check in `spell_proc_event`
Remove unused RewardSinglePlayerAtKill result.
Make spell_proc_event.SchoolMask unsigned.

Also use byte length hex for school mask in mangos.sql data.
Add 16246 proc to mangos.sql
Implement glyph 45623.

Thanks to Most_Mangos, DonTomika, darkstalker  for dollution research.
Drop unused member in VisibleNotifier structure and related functions

(based on SilverIce's repo commit e678555)
Also applied mangos code style to GridNotifiersImpl.h
Move item disenchanting static req. checks to server start.
Fix damage for 14278 and 16511 and ranks when dagger is equipped
Change HandleLearnAllMySpellsCommand to learn only player's spells
New LogFilter_DbStrictedCheck filter for DB devs

It's enable by default (prevent show related output) but
in disbled case allow show useful for DB developers different
more stricted DB check output at server loading, including

* Absent GO trap template referecned in some another GO template
* Not set (0) unit class in creature_template
* Absent disenchanting loot for items marked as disanchantble

This all cases can or hard fixed in one step or show false cases y different 
reasons.
That why filter active by default.
Fixed unexpected C++ code parsing with *FILTER_LOG in 'if'

YTDB 325

Code:

+ all fixes from forum;
+ fix spawn;
+ quest scripts;
+ mob's gossip menues;
+ new teplates from WDB;
+ fix stats of NPC: Alterac Valley
+ fix data "disenchant_loot_template"
+ update tables "*_template" by WDB
+ processed 280 caches