Mangos + YTDB + Scriptdev2 + Changelog

**DjAligator** · 21-12-09, 03:10 AM

Mangos 9021 - 9043
Implement item 21213 effect work.
Fixed small typo in creature_template.difficulty_entry_N checks.
Fixed some hunter sting affects.

* spell 1978 and ranks RAP bonus
* spell 53209 affect from spell 3034 dot.
Fixed RAP bonus percent for spell 56641 and ranks.
Implement talent 63373 and ranks.

Idea with AddTriggeredSpell use suggested by darkstalker.
Implement ACHIEVEMENT_CRITERIA_REQUIRE_INSTANCE_SCRIPT.

This achievement criteria requirement type let set in table
`achievement_criteria_requirement`
that specific criteria id for achievmenet connected with some instance
must be checked by new InstanceData call
bool CheckAchievementCriteriaMeet(uint32 criteria_id,Player const*
source, Unit const* target, uint32 miscvalue1)

It expected to be used for cases: kill boss without raid members death or
for some limited time
or without kill before some other boss helpers and etc. Implementation
expected base at collection some data/counters update
in instance data at specific event and then make check by query and retunr
success for specific criteri or fail requirements.
Restore spell bonus apply to dot damage for 17962 damage
calculation.

In fact reverting wrong part of my one from prev. commits.
Better error output for
ACHIEVEMENT_CRITERIA_REQUIRE_INSTANCE_SCRIPT.
Fixed spell 0451 and ranks buff apply.

In fact drop now wrong redundent code.
Fixed: remove spell 30451 and ranks buffs stack at another arcane
spells.

(cherry-picked from commit 8dbbc7b)
Fixed: remove talent 44404 buff at spell mod apply triggering.
Correctky cast rank 2 mana regent triggred effect for 53228 and
ranks.
Fixed percent mana regneration from spell 53228 and ranks buff.
Add internal cooldown for item 47215 effect.
Attempt make more fast and less hackish spell target checks

* Enable server side recheck clear negative to friend or positive to enemy
casts that already checks at client side
* Use more fast way check in similar cases for non-players, and fall back
to old way in unclear (for while at least)

Please report if some spell stop propertly casted at friends/enemies.
Typo in function name.
Cleanups in spellmode apply code.

* Add constructores for spellmode creating instead explcit fields init
* Use uint32 for family mask 2 instead unneded uint64

Also drop one from manual applies for uno-existed now spell.
Update highest threat enemy at move to offline list.

It will restored if still highest at move back and fix
at least visual bug with GM-mode on still show for GM
as highest threat enemy for creature.
Allow have more one hunter aspect from different casters.
Update code for talent 17056 and ranks correct work.
Move enum CastFlags from eventAI to creatureAI for access to all AI
Remove double apply bonuses for spell 635/31935 and ranks

One time in code and second time by DB data.
Fxied build at *nix systems.

Added and Dual spec and anticheat Enjoy

**DjAligator** · 24-02-10, 01:28 PM

Mangos 9436 - 9444
Correctly display the party leader's name in chat
Move waypoint's GetResetPosition function body to .cpp.
Add base code of effect for spell 45668, but in commented form.

The spell triggering 45668 need to be corrected before it can trigger this
as expected.
Auto-exclude from git tracking changes any non universal binding
subdir files

Also resolve small exclude conflict for dep subdir.
Store in plauer spell list structure instead pointer.

Just not reason in element persistanse storage as std::map
store pointer to structure with size < 16 bits.
Add dummy effect of spell 50133/43882
Add dummy effect of spell 44454 and script effect of spell 44455
Add dummy effect of spell 55818
Add script call EffectAuraDummy, called at dummy aura(4)
apply/remove