Mangos + YTDB + Scriptdev2 + Changelog

[DjAligator]

Mangos 9542 - 9577
Make MovementGenerator::GetMovementGeneratorType() const
Really call ACHIEVEMENT_CRITERIA_TYPE_WIN_BG

Also make more wide set achievement type criterias expected requirement in
DB table.

Original patch in achievement call part provided BudIcePenguin.


Implement CONDITION_NOITEM.
Rename ObjectDefines.h -> ObjectGuid.h

Also move unrelated generic defines to Common.h
Less strict check in spell CheckTarget, and allow triggered spell.

Unit may be not selectable, but spell may be expected to target this unit
in any case.
Mostly known problem with npc->npc spells and dummy/triggered spells from
AI side.


Implement ObjectGuid wrapper for guid value

Only one example (mostly) case converted to use it.
Need lot work for finally switch to class obly use, so old low-level
defines still exist also (while used).
But some unused low-level defines dropped.


Lost new ObjectGuid.cpp at prev. commit.
One more typo :/
Hide unsafe templated ByteBuffer::append function only for internal
use.
Add and use PackedGuid wrapper.

Also
* use more wide bytebuff << >> operators for objects
* use at read packet faisl alsways exception way instead some time used
bool results.




Make some compiler happy with forward class declaration.
Make GCC really happy...
Fixed possible runtime crash.
Makes some arguments as references in some ByteBuffer operator
methods.
Allow summoned creatures use MovementType == RANDOM_MOTION_TYPE

Using creature_template.MovementType as default. For normal spawned
creatures, data from creature table will still apply and override
_template.
Radius is 5.0 as default, but may be changed in real-time from ai scripts
using function.
Move the code of glyph 55672 to a better place
Fix a typo from prev. commit:/
Update AiReaction enum.




Fixes possible runtime crash added by 9551
Fixed typos in header guards
Another update of AIReaction enum (and comments).
Use DEFAULT_WORLD_OBJECT_SIZE in ObjectPosSelector if size == 0.

This should fix a freeze in ObjectPosSelector.
If size == 0, m_anglestep became 0 -> freeze.





Remove some trailing whitespace and add comment for last commit.
Add detection code for partly cave area 3780
Restore build
] Add 2 unknown target flags.
Add function to manually start random movement.
Fix spell 60772
Implement glyph 55692
Create and use ObjectGuidGenerator/IdGenerator template classes.

* This is let finally hide guid structure in ObjectGuid.h/.cpp code.
* Shared related code.



NOTE: while switch to use new clasess one more problem has been detected
with not-safe code in .pdump work for future per-map multi-threading.
It's need rewrited before will possible safe use in like case.
For current single world thread case it's safe.
Add script calls for GameObject GossipHello and GossipSelect
Add structure and prevent spam for some LFG opcodes.
Thanks to Spp for help with researching CMSG_LFG_JOIN.




Add config option Network.KickOnBadPacket. If enabled, player will
be kicked on badly formatted (wrong structure) packet.
Use proper template arg instead default value
Use ObjectGuid in Map object stores/world access/search.
Implement SCRIPT_COMMAND_CREATE_ITEM to use when no spell exist
Implement SCRIPT_COMMAND_DESPAWN_SELF (self = creature in this
context)



YTDB 298
+ All fixes from forum;
+ spawn;
+ quest scripts;
+ mob's gossip menues;
+ new templates from WDB
+ filling "points_of_interest" - Dalaran, Shattrath, Exodar, Silvermoon
+ filling table "gossip_menu_option"
+ fix data "achievement_criteria_requirement"
+ fix data "milling_loot_template"
+ fix spawn "Razorfen Downs"
+ fix spawn "Scarlet Monastery"
+ full respawn loot "Trial of the Crusader"
+ processed 183 caches (3.3.2)

[Dimman]

Nice to see a good & updated project here on mmopro +Rep