Long time no updates




Mangos 10659 - 10737
Code:
Fixed mistake in [10653] that causes player to fall from the transport at teleporting to another map
Make quest for game event be independent of source

Create new table and convert existing data.
Simplify how game event quests are activated during event by adding generic function to set quest active/inactive.
Any quest in game_event_quest are disabled until event start (and deactivated once stopped)
Update VC10 filers for new ACE
Implement partly item looting

* Not deleted normal item loot at first loot window close.
* Save current item loot content to DB for later continue looting.
* Cleanup spell effect SPELL_EFFECT_OPEN_LOCK check code
* Cleanup Player::AutoStoreLoot calls
Fix totem animation at normal unsummon.
Rename arena_team_stats fields for better fit to stored values.
Allow use faction data for cases raceMask==0

Also some related code cleanup
Implement ACHIEVEMENT_CRITERIA_TYPE_HIGHEST_*_RATING
Timed Achievements, Fail-Support and Opcodes
Implement CONDITION_*ITEM_WITH_BANK conditions.

Similar CONDITION_*ITEM but including character bank content in counting.
Fixed mana amount for overheal case for talent 31785 and ranks.

Also thanks to Wojta for patch code improvements.
Restore build at real C++ compilers after recent timed achievements commit.
Convert some Unit owner/etc guids to ObjectGuid way.
Allow damage own pet in sanctuary.

Also mome repeating code to new function.
Include `item_loot` into pdumps
Show some SPELL_AURA_MOD_DODGE_PERCENT auras as debufs as expected.
Ignore BOA items reputation requirements at use.

Item reputation requirements checked at buy, and in quest case
related quests expected to have own reputation requirements
preventing rewarding items with not fit reputation requirements.
Fix repeating looting for milling/prospecting.
Send to creature/etc Update call real diff from last update and use it.

Now in case when creature/etc some tices not updates in result stay
in not active (no near players or active objects) cell some important
timers (corpse decay, summon timers, group loot expire, aura durations, etc) will
updates at real diff time from last prev. update call.

For some systems added exclude use real diff time because current limitations
like move generators. So its stay use last tick diff and considered freeze and
skip all time while creature in not active map part.
Revert "[10675] Ignore BOA items reputation requirements at use."

This reverts commit 4ce902e5d9c3cfc635c0eff1ba3552da5ecd0c5b.

Check done at client side so useless skip it at server side.
Proper fix expect show diff items in vendor list depndent from required reputation.
New table `npc_vendor_template` for comon item data for diff vendors.

In vendor list show own vedor items + template ites if any.
Vendor template item lists selected by id stored in creature_template.vendor_id
Update item buy code for new way vendor item lists work.
Added new Cell::Visit* functions to visit grids with center in (x,y) coords

* This fixes possible problems with Spell::FillAreaTargets(center of search should be (x,y) position, not spell caster's position)
* Cleanup Cell class, removed old and unused code
New table 'item_convert' for convertion items.

* Implment vendor at show replace BoA item with reputation requirement
  by identical item without rep. reqs for player that fit this requirements
  of original item.

* Table also can be used for store item convertion data form one team items
  to similar other team items. This case not impement but added function easy
  used for it.

* Note: strict single convert for item not created problem for both way use:
  item converted for same team or all, can't be original item for conversion to
  another team.
Revert "[10677] Send to creature/etc Update call real diff from last update and use it."

This reverts commit 10784a8c7cc81c468b5411e973d36ecf31de9603.

Main reason: impossibility for me as commiter test problem and fix all corner cases problems.
Fixed mangos.sql `creature_template` default content after adding vendor_id
Fixed creature_template loading after vendor changes.

Thanks to insider42 for problem research.
Update outdated comment
UInt32 timer class copies instead using time_t timers for mstime cases.

Also cleanup weather update code and some random code cleanups.
New version of patch for send real diff from last update.

In new version last update time stopred for specific Cell that store all world objects
placed in it. All objects of Cell updated (or not updated) in same time.

Original version provided by ciphercom.
Restore some item checkes for temporary loot case.
Fixed *nix build problem after recent commits.
Add dummy effect of spell 53475, 53487 and 54015
Fixed some GCC warnings and code errors.

Thanks to freghar for provide cleaned list of warning messages.
Fixed wrongly use %d for guids in DB queries.

This can affect correct result in cases big guid values
(out of range for possitive part of int32 range) at x86 platforms.

Some other cases addded in addition to original patch fixes
where %d wrongly/unsafe used for unsigned values.
Update SpellEntry based on the work of TOM_RUS
Use portable ACE way msecs time value calculation

Avoid use unsafe code for non-Windows platforms
Thanks to Marik for research the problem and Ambal for helping me with this patch
Cleanup some death state enums usage.
 Avoid selection despawned creatures as spell autoselected targets.

Original patch provided by virusav.
Less strict check for update at war state for factions

Clarify in comments of recent added spell dummy effect
Compute cell area bounds for active objects in the same way like it done for players
Add debug note for not implemented summon property group
Remove unused structure GridUpdater.
Correct check percent spell costs in AI::CanCast

Also use uint32 for spell cost fields/results
Fixed loading mails broken after [10692]
Check SPELL_ATTR_IMPOSSIBLE_DODGE_PARRY_BLOCK for special attacks.
Add the option to close gossip window in gossip system

Field action_menu_id in gossip_menu_option table can be set to -1 where close gossip is expected, instead of sending a new menu.
Simplify CellArea calculation
Implement talent 30326 for spell 5138.
Move Glancing Blow early in melee outcome results.
Update ACHIEVEMENT_CRITERIA_TYPE_LOOT_* with group roll.
Prevent wrongly use transport guid as unittarget in spell targets
Fixed typos in my previous commit
Check localization data for existance main table entres.

Data will skipped for nonexistent entries, and reported with
disabled LogFilter_DbStrictedCheck filter.
Startup checks for `gossip_menu` and `gosip_menu_option` table data.

Existance `gosup_menu` id refercned from gameobject field and unused meni ids
activated only with disabled LogFilter_DbStrictedCheck.
player/group instance binding fixes.

* Use anum instead raw uint8 type in args
* Fixed crash when gm at continent invite to group gm in instance
  and then teleport to instance using .goname.
  When group leader teleport to instance it must get group bind instead solo bind.
* In other semilar cases detection report error as before but replace solo by group bind instead
  assert crash at enter to map.
Avoid unexpected error at action_menu_id < 0 after recent loading checks adding.
Fixed move in inventory items with ItemLimitCategory.
Typo show commit before revet all realddiff one more time.

Typos show that in fact "working" has been result typos diabled state for relamd.
Cell-based way have not avoidable problems with case when object added to not active
long time Cell. If someone find more working sollution it can be readded ofc.
Revert "[10716][10688] New version of patch for send real diff from last update."

This reverts commit 8398a55fa274471daae115e00c627b299a3fdbbd.
This reverts commit 06e2d6859ba3d7fd47be72c23a64e68ae039701f.
Partly revert "[10687] UInt32 timer class copies instead using time_t timers for mstime cases."

This reverts commit 967877fefd91e00895f9790dc006b532b94d41b7
in part MapManager/World timers.

Main reason: unclear source cases wrong mstime diff generation at WorldRunnable level at *nix systems.
So need have existed in past hacks that skip its.
Implement proper calculation quest honor reward.

Now server side rewar same as reported at client side.

Also thanks to KiriX for patch prepering to commit and testing.
Implement check `gossip_menu_option`.`npc_option_npcflag`.

For cases main menu options used by creature but impossible show in result absent
related npcflags for any creatures used that menu.
Use required_quest instead of _heroic for non_instance areatrigger teleport
Fill target map for TARGET_RANDOM_NEARBY_DEST(b) cases.

Corrects ~35 spells, where most has summon effects.
Backports from 400 branch.
Add dummy aura effect of 51405 and dummy effect of 51420
Fixed wrong error message for quest related areatriggers.
Fix TARGET_AREAEFFECT_CUSTOM, need to obey type when DB target entry exist
Add a few comments for SUMMON_PROP_TYPE_CRITTER
Correct one SQL in tools, table was renamed.
Map system re-engineered. Special thanks to Blueboy for tests.
Fix Deathly Stare spell
Add dummy aura effect of spell 47178 and dummy effect of 47176

Note: see comments in code for spell 47176
Check if Pet's target is a valid target (isTargetableForAttack)
Remove redundant isAlive-check, thanks LordJZ for notice
Not send session fields as args into HandleMoverRelocation/VerifyMovementInfo.

Also mark args as constant where expected in this functions.
Implement defencive guardians pet type for creatures like 28120
Rename and clarify SummonPropertiesEntry.Type->Title field meaning.

This also show why we have some problems with sorting sumons by types base at this field.

Thanks to TOM_RUS for research.
Fixed spell 51420 work by use recently added protector pets as expected.

Thanks to NoFantasy for problem research (and prev. new pet type adding case research aslo) ;)
Fixed  unexpected typo in prev. commit.
YTDB 351
Code:
+ all fixes from forum
+ fix spawn
+ quest scripts
+ mob's gossip menus

+ all fixes from forum
+ fix spawn
+ quest scripts
+ mob's gossip menus

+ all fixes from forum
+ fix spawn
+ quest scripts
+ mob's gossip menus