Thread: Mangos + YTDB + Scriptdev2 + Changelog

Mangos 9460 - 9473
Spellpower bonuses for spell 47540 and ranks.
Some another cases when movegen can be lost while updating.
Compile fix under GCC.
Add script effect of spell 45691 and dummy effect of 45685
Spell effects of itemset 883 and variants.

Make passive aura buffs/debuffs always show at not-casters.

This fix case when some racial party passive bufs not show for party
members.
Implemented SOAP in MaNGOS

- removed deprecated code from RASocket
- allow more than one login at a time on the RA console
- added gsoap library for handling SOAP requests
- removed deprecated mangos_string entry

Thanks to:
- Derex for reporting a bug which occured if more than 1024
players were connected [poll() vs select()]
- caeruleaus for adding windowsbuild support
- vladimir for suggesting a different thread starting order
- fdb_ for suggesting SOAP in the first place

Add dummy effect of spell 51330
Restore compile Win32/x64 (VC80/VC90), add correct include dir to
all builds
Add dummy effect of spell 51333
Add dummy effect of spell 42287
Add dummy effect of spell 43036

Revert "[9465] Make passive aura buffs/debuffs always show at
not-casters."

This reverts commit 43f6a355e5a94c56c8fd6b881b572e1d685f046c.

Need more work.
Apply recent sql update to mangos.sql itself.

Mangos 9474 - 9501
Implement negative totem effect apply for 30706 and ranks.
Add and use TotemSlot enum type
Add basepoints array to Unit::HandleDummyAuraProc
Implement glyph 45776
Reimplement Aura::IsNeedVisibleSlot

Rewrite base at area aura type check
* For positive area aura types show at non-caster target or caster-totem
or non-passive aura at caster
* For negative area aura show at non-caster target
* For other auars show at any target if non passive auras or totem-caster
Use Clear call in MotionMaster::Initilize

Function can be called from deep code in time MotionMaster::Update.
So need use safe way cleanup with possible delayed movegens deletion.
Add aura dummy effect of spell 29266
Add dummy effect of spell 51276
Implement 48266, and 50365, 50384, 50391 and ranks.

Original patch provided by laise.
Not affect anything but not nice typos...
Add dummy aura effect of misc feign death spells

Please note that it may not be correct to handle them all in the same way.

Some more research should be done regarding the whole issue with creatures
and faking death (cheaters) and a possible difference between the spells.
Fix a value in movement update blocks with update flag
UPDATEFLAG_VEHICLE
Increase reserverd stack size for mangosd up to 4Mb at Windows

Most Unuxe/Linux OSs have by default 4Mb as max stack size for application
by default.
VisualStudio for x86/x64 set 1Mb by default. In result at Windows possible
more often
stack overflow crashes in cases when Unux version work fine. So we fix
this not nice
difference.

VS10 version not included. If someone prepare patch for VS10 case it can
be added to repo.
Fix a typo in Pet::addSpell
Fixed semaphore locking on non-posix systems
No reason have different code for apply/remove for this spells.
Make common apply/remove handler for another spell group in
HandleAuraDummy
Restore code commenting style after 9489/9490

Adjust comment style for rest of function and some additional code style
cleanup.
Some cleanup in effects table.
Fixed wrong spell cast at talent 50391 and ranks apply case.
Implement SPELL_EFFECT_JUMP (41).
Show overheal from HoT in combat log.
HomeBind fixes.

* Use area id instead zone id for home bind zone info as expected.
This will for example proper show capital name in area himebinding for
capital; tavern.
* Clarify that player create zone in fact is area (subzone)
* Implement SPELL_EFFECT_BIND for normal homebinding.
Also support spell target position mode used in 53823/53821 spells
* Add Spell::EffectEmpty for mark spell effects that used but not expect
any code in handler.
Example weapon spells that used just as known spell markers for client.

Original patch idea inspirit by Sadikum patch suggestion.
Implement basic use of SPLINETYPE_FACINGTARGET

Adjust related helper function accordingly.
Restored build on *nix
Add replacement spells for GO type 10 that may have dummy spellId
in _template
Update SpellCastResult enum to 3.3.x state.
More speel effects table cleanups in comments
Implement item limit category inventory mode.

* Now expected item limit categories (for example for item 5513 and
related)
correctly limited by its amount in inventory.
* Provide and use additional arg in SendEquipError for alt. way get
affected
item prototype. This let send to function item id and prevent crash
client at
limit category equip errors that required item prototype data.

Mangos 9502 - 9541
Update SpellCastResult enum to 3.3.x state.
Updated behavior of auto shot according to the client changes.
Removed obsolete code for spell 18096 and ranks.
Removed facing limitation for spell 2764.
Add missing AI calls to inform summoner of summon-related events



Implement SPELL_EFFECT_RESTORE_ITEM_CHARGES

Also it application in special case of item 5513 and similar.
Finish impement new functionlity for item 5513 and similar.

* Implement recharge low rank item in inventory.
* Implement recharge item at loading after 15 offline mins
Move custom data from item spell charges sign to new field
`NoConsumable`.

Some items with negative by defaul charges not expected to be deletedt at
no charges.
In past this fixed by using positive charges amount in like cases in
different from
expected negative value. Adding new field for avoid this.



Gameobject casting improvements.

* Add IsHostileTo/IsFriendlyTo and implement expected way checks for diff.
world object types.
For controlled object check redirected to specific owner, for wild
gameobject base at gameobject faction.
If faction not set expected to be hostile to anyone.
* Update grid searchers to be usable with world object instead only unit
case.
Some grid searches lost redundent second object arg,
AnyAoETargetUnitInObjectRangeCheck lost hitHidden arg
(for hitHidden==true case added new
AnyAoEVisibleTargetUnitInObjectRangeCheck)
* Updated grid searchers used with gameobject area casts now.
Note: Gameobject area spell cast animation will still wrong show around
cast triggering target instead
center around gameobject.
* In case gameobject aura apply to target for restored use target itself
as caster because
we not have currently another way apply aura form wild gameobject.
Hotfix for low chance crash at not accessable gameobject cast.
Spell 16952 and ranks will now correctly proc from all cat form
abilities that add combo points
Fix spell 48920
Implement opcode CMSG_HEARTH_AND_RESURRECT
Fix a possible exploit in CMSG_HEARTH_AND_RESURRECT
Fixed talent 50391 and ranks in part apply rune cooldown expire
speed.

* Apply rune cooldown buff only for spell 48265
* Implement SPELL_AURA_MOD_POWER_REGEN_PERCENT work for POWER_RUNE

Thanks to Laise for problem research.
rewrote RA console using ACE

- moved SQL pinging to SqlDelayThread
- use sAccountMgr instead of explict sql queries
Implement account associated execute for RA commands

* Now at login by RA-connection RA-connection use account id/access level
for commands execute. So at login with moderator access by RA-connection
you
can execute only moderator level commands. For administrator level
accounts
allowed execute only console level commands if new config option
RA.Stricted = 0.
For security reasons by default RA.Stricted = 1.
* RA-connection executed commands now logged for associalted account id
* Some own account related commands allowed execute in RA-connection

NOTE: config version updated because RA.Stricted = 1 not compatible with
old
way work and this can break tools thta use RA-access if it not
disabled.
Yuo will need update mangosd.conf.
Remove linking mangosd with sockets library.

Recent RA reimplementation added by Arrai remove using sockets library for
last part mangosd code.
This let not link anymore sockets library with mangosd.

Now realmd is last sockets library user.
Prevent possible memory leak in WorldSession
Let build map extractor at Mac OSX

Also restore build at Windows (Win32 not have unistd.h)

Win32 ad.exe binary updated but not expected any functional differences.
Implement spells 58600 and 58601
Stacking Auras from dual wild weapons.
Use cooldown data from gameobejct trap tamplate if provided.
Implement effect SPELL_EFFECT_TEACH_TAXI_NODE(154)

Original patch writed by Sadikum.
Fix a typo from commit 9512
Fix CRLF in 9512_01_mangos_spell_proc_event.sql.
Avoid apply spell bonuses to glyph 42397 effect.
Make Player::IsValidPos const
Fixed check for SPELL_AURA_ALLOW_ONLY_ABILITY

Also remove public access to SpellAura::m_spellmod for avoid another hacks

with it use. Spellmods only for Player::ApplySpellMod use.
Fixed apply stamina part of 48263
Fix typo in opcode name.
Use selected target for target mode 38/46 when provided.

For cases where provided target is not valid (or not provided), normal
closest in range will be used.
Attack Power bonus for spell 64382.
Some percent target max health spells.

Thanks to timmit for research.
Implement item 46017 effect.
Avoid proc item 46017 effect from DoTs.
Implement proper work spells 59465 and 56151.
Item 23836 effect and spell 54757 not affcted caster spell power.
Implement cooldown reset part for spell 60970 work.
Implement first target of spell 1064 and ranks boost from 61301.



YTDB 292

+ All fixes from forum;
+ spawn;
+ quest scripts;
+ mob's gossip menues;
+ new templates from WDB;
+ fix respawn ores/viens - Outland/Northrend
+ fix data in "achievement_criteria_requirement"
+ processed 150 caches (3.3.2);

Once again, thank you DjAligator .

Mangos 9542 - 9577
Make MovementGenerator::GetMovementGeneratorType() const
Really call ACHIEVEMENT_CRITERIA_TYPE_WIN_BG

Also make more wide set achievement type criterias expected requirement in
DB table.

Original patch in achievement call part provided BudIcePenguin.


Implement CONDITION_NOITEM.
Rename ObjectDefines.h -> ObjectGuid.h

Also move unrelated generic defines to Common.h
Less strict check in spell CheckTarget, and allow triggered spell.

Unit may be not selectable, but spell may be expected to target this unit
in any case.
Mostly known problem with npc->npc spells and dummy/triggered spells from
AI side.


Implement ObjectGuid wrapper for guid value

Only one example (mostly) case converted to use it.
Need lot work for finally switch to class obly use, so old low-level
defines still exist also (while used).
But some unused low-level defines dropped.


Lost new ObjectGuid.cpp at prev. commit.
One more typo :/
Hide unsafe templated ByteBuffer::append function only for internal
use.
Add and use PackedGuid wrapper.

Also
* use more wide bytebuff << >> operators for objects
* use at read packet faisl alsways exception way instead some time used
bool results.




Make some compiler happy with forward class declaration.
Make GCC really happy...
Fixed possible runtime crash.
Makes some arguments as references in some ByteBuffer operator
methods.
Allow summoned creatures use MovementType == RANDOM_MOTION_TYPE

Using creature_template.MovementType as default. For normal spawned
creatures, data from creature table will still apply and override
_template.
Radius is 5.0 as default, but may be changed in real-time from ai scripts
using function.
Move the code of glyph 55672 to a better place
Fix a typo from prev. commit:/
Update AiReaction enum.




Fixes possible runtime crash added by 9551
Fixed typos in header guards
Another update of AIReaction enum (and comments).
Use DEFAULT_WORLD_OBJECT_SIZE in ObjectPosSelector if size == 0.

This should fix a freeze in ObjectPosSelector.
If size == 0, m_anglestep became 0 -> freeze.





Remove some trailing whitespace and add comment for last commit.
Add detection code for partly cave area 3780
Restore build
] Add 2 unknown target flags.
Add function to manually start random movement.
Fix spell 60772
Implement glyph 55692
Create and use ObjectGuidGenerator/IdGenerator template classes.

* This is let finally hide guid structure in ObjectGuid.h/.cpp code.
* Shared related code.

NOTE: while switch to use new clasess one more problem has been detected
with not-safe code in .pdump work for future per-map multi-threading.
It's need rewrited before will possible safe use in like case.
For current single world thread case it's safe.
Add script calls for GameObject GossipHello and GossipSelect
Add structure and prevent spam for some LFG opcodes.
Thanks to Spp for help with researching CMSG_LFG_JOIN.




Add config option Network.KickOnBadPacket. If enabled, player will
be kicked on badly formatted (wrong structure) packet.
Use proper template arg instead default value
Use ObjectGuid in Map object stores/world access/search.
Implement SCRIPT_COMMAND_CREATE_ITEM to use when no spell exist
Implement SCRIPT_COMMAND_DESPAWN_SELF (self = creature in this
context)



YTDB 298
+ All fixes from forum;
+ spawn;
+ quest scripts;
+ mob's gossip menues;
+ new templates from WDB
+ filling "points_of_interest" - Dalaran, Shattrath, Exodar, Silvermoon
+ filling table "gossip_menu_option"
+ fix data "achievement_criteria_requirement"
+ fix data "milling_loot_template"
+ fix spawn "Razorfen Downs"
+ fix spawn "Scarlet Monastery"
+ full respawn loot "Trial of the Crusader"
+ processed 183 caches (3.3.2)

Nice to see a good & updated project here on mmopro +Rep

Mangos 9578 - 9599
Use ObjectGuid in visibility sets
Use ObjectGuid in some loot code.

Also use ObjectGuidSet instead std::set<ObjectGuid>
Add ObjectGuid const& Object::GetObjectGuid() and restore build.
Fixed apply damage reduction to melee/ranged damage.
Send looted creature guid in proper field of loot packets.

Also use ObjectGuid in related functions.
Fixed speed recalculation at remove .mod speed rate while
mounted/etc.
Continue fix loot roll packets and related code.

* Propertly send itemSlot field and use it with looted target for roll
selection.
* Remove references to NumberOfPlayers useless data send in args
* Fixed long existed bug with roll show when single player from group can
roll item.
* Fixed possible crash at player leave group while item roll
* Fixed wrong item amount in stack in rolls inreasult use non-initilized
field as info source.
* Remove unused item guid field from Roll and not lost for nothing item
guids for this.

Thanks for help in research to TOM_RUS and j4r0d.
Restore lost `return` in prev. commit.
Remove a useless include
Fixed freeze after recent loot roll code changes.

Thanks to j4r0d for testing.
Really fix freeze :/
Add additional field for storage of speed_run rate of creature

This allow independent rate of walk vs run speed. Existing field renamed
to explicit speed_walk.
Note that default database rate for run is a result of the most common
value seen, 8.0/7.0
fixed mangos.sql
Fixed rest state remove at leave tavern
fix crash with ACHIEVEMENT_CRITERIA_REQUIRE_INSTANCE_SCRIPT

BattleGroundMap has no GetInstanceData() function
Fixed bug in instance binding in case heroic/25-man raids
difficulties

In fact typo in my old commit at adding support MapDifficulty.dbc.
Allow UTF8 strings via SOAP
Fix the amount of mana restored by spell 68082
Use area trigger zone check for inn leave case.

This is still have false cases but will more correct for specific area
triggers.
Also let cleanup code and store less data for Player.
create battleground map at bg creation

when a bg gets created it will also get it's map
(old behaviour was, that map got's created when first player entered the
instance)

the reason why battlegroundmaps aren't instantiated with a player object:
* the only information from player-class we need is
player->GetBattleGround()
also we can't use anything else
(e.g. playerlevel can be outside of bg-levelrange)
-> cause bgs depend pretty much on their maps this caused circualr
dependencies between map,bg,player
* battlegroundmaps will _always_ be prepared by the bgsystem to set
the proper data
* there is not much shared in the creational process with dungeonmaps
even the functioncall is different since players need to enqueue
first for bgs,
therefore again the player's way to that instance is only through
the bgMgr
update battlegrounds per map + cleanup at delete

this will be useful, if we have multithreaded mapupdates one day

since i couldn't reproduce any errors regarding to self deletions of
battlegrounds i removed the m_deleteThis variable
Adding a few research comments for unit_flags and rename one.

Mangos 9600 - 9620
restored work of DeleteAllBattleGrounds
check for UNIT_FLAG_OOC_NOT_ATTACKABLE in
DynamicObjectUpdater::VisitHelper

this will solve the problem that spiritguides could get attacked
(for instance with spell 2121)

thx to DasMy who helped with research
Simplify creating mail draft with content text, cleanup includes.
Implement use of UNIT_FLAG_PASSIVE for creature.

Add function to check creatures own ability to initiate an attack in
MoveInLineOfSight.

Prevent unexpected call to AttackStart when having unit_state
stunned/died
SetSummonPoint for any summoned creature.

Should fix a crash where summoned attempt moveRandom without having a
valid summon point.
Send packed caster GUID for AFLAG_NOT_CASTER.
Fix SMSG_GUILD_INFO time part.
Fix typo that broke guild creation timestamps
Send zoneUnderAttack from EventAI if creature is a guard.
Use more readble format for default `gossip_menu_option` values.
Add index for some tables in characters DB.
Add to SendMonsterMove var args for optional values.

Also drop currently unused Unit::m_InteractionObject
Use stdarg.h instead outdated varargs.h

This must restore build at *nix
Objects HIGHGUID_MO_TRANSPORT not have entry part in guid.
Send AFLAG_NOT_CASTER only if casterguid == targetguid.
Fix ByteBuffer::appendPackGUID appending a superfluous byte.
Add WorldPacket.h to vcproj files.
More use ObjectGuid in spell/etc code
Reset more UNIT_FIELD_FLAGS at login.

Resolve linking problems for script DLLs




YTDB 313
+ All fixes from forum;
+ spawn;
+ quest scripts;
+ mob's gossip menues;
+ new templates from WDB
+ fix spawn and pool for all viens
+ fix data "creature_equip_template"
+ Icecrown Citadel (Raids) - all modes: N10/N25/H10/H25 - ("alpha") - (No loot from Lich-King in heroics)
+ processed 260 caches (3.3.2)
+ Thanks YTDB forum & UDB forum & CTDB forum & TDB forum, for the WDB caches 3.3.2.
+ All fixes from forum (Look under Accepted Patches Section);
+ Spawns;
+ Quest scripts;
+ Mob's gossip menus;
+ New templates from WDB
+ Correction of the fields in "creature_template" following WDB
+ Correction of spawn in "Maraudon"
+ processed 204 caches (3.3.2)
- Icecrown Citadel (Raid) - Is closed for now (The spawns are fully completed including Lich King) , Loot is 99% completed on all the difficulties, we will polish Icecrown in the next commit (Lich King is under "Repair" there are some questions about him) + read cache topic (And help us out))