Thread: Mangos + YTDB + Scriptdev2 + Changelog

Mangos 9436 - 9444
Correctly display the party leader's name in chat
Move waypoint's GetResetPosition function body to .cpp.
Add base code of effect for spell 45668, but in commented form.

The spell triggering 45668 need to be corrected before it can trigger this
as expected.
Auto-exclude from git tracking changes any non universal binding
subdir files

Also resolve small exclude conflict for dep subdir.
Store in plauer spell list structure instead pointer.

Just not reason in element persistanse storage as std::map
store pointer to structure with size < 16 bits.
Add dummy effect of spell 50133/43882
Add dummy effect of spell 44454 and script effect of spell 44455
Add dummy effect of spell 55818
Add script call EffectAuraDummy, called at dummy aura(4)
apply/remove

Mangos 9445 - 9459
Possible fix often crashes in waypoint movegen.

Thanks to DrKLO for research source of problem!
Compile fix in MovementGenerator.cpp

Also added few newlines to end of files to satisfy GCC.
Typos and missing info in mangosd.conf

Provided by erickeir and unknown author (sorry, lost info about who point
me to first typo)




Ignore anything untracked in src/bindings/

NOTE: works only on directories

(only modification / deletion of tracked files
will show up in "git status")

To force-stage a file/directory, use "git add -f",
an exception was made for universal/ .

Signed-off-by: freghar <[email protected]>

(based on commit 0a4057f)




Fixes for the Solaris platform.
Implement item set 887, 251, 232 spell effects.
Added new config option for arena queue announcer.

Option Arena.QueueAnnouncer.Enable removed so if it used
need update mangosd.conf to new options use.

(based on insider42/mangos commit 211506f)




Replace battleground announcer options.

* Drop Battleground.QueueAnnouncer.Enable and
Battleground.QueueAnnouncer.PlayerOnly
* Add Battleground.QueueAnnouncer.Join with 0..2 values (1=to joined
player, 2=to world)
* Add Battleground.QueueAnnouncer.Start for start bg event

Also fixed bug when not rated arenas announced as BG announces
Also lost mangosd.config changes from prev commit.
Implement heal bonus from talent 62905 and ranks.
Fixed some time existed multi-map taxi problem.

Interrupt taxi movegen at far teleport time with remove related state.
Far teleport triggered code not expect this state set.
Check glyph index send by client at glyph adding to prevent
cheating.
Fixed spell proc code for mixed proc event cases.

* Allow spells with multiple procEx flags to trigger also with 0 dmg, if
current
procExtra is no normal hit (e.g. block and normal hit as flags -> all dmg
blocked).

* Also allow proc at hit as result partly block. This fix case from
unknown author
prepered by KAPATEJIb.
Implement spell/attack power bonus for 59547 and similar spells.
Also fix build in prev. rev. in result my not added changes.
Add exception for spell 51912 and then trigger 45668 as expected

Also remove commented code for spell 45668
Make spell 47540 and ranks channeling interruptible

In fact make triggered spell replace main spell for channeling.
This also let drop hack for target death case interrupt channeling for
spell.





YTDB 287
+ All fixes from forum;
+ spawn;
+ quest scripts;
+ mob's gossip menues;
+ new templates from WDB
+ update all PvP-vendors;
+ Full respawn viens: Azeroth
+ fix data in "achievement_criteria_requirement"
+ processed 119 caches (3.3.2)

Mangos 9460 - 9473
Spellpower bonuses for spell 47540 and ranks.
Some another cases when movegen can be lost while updating.
Compile fix under GCC.
Add script effect of spell 45691 and dummy effect of 45685
Spell effects of itemset 883 and variants.

Make passive aura buffs/debuffs always show at not-casters.

This fix case when some racial party passive bufs not show for party
members.
Implemented SOAP in MaNGOS

- removed deprecated code from RASocket
- allow more than one login at a time on the RA console
- added gsoap library for handling SOAP requests
- removed deprecated mangos_string entry

Thanks to:
- Derex for reporting a bug which occured if more than 1024
players were connected [poll() vs select()]
- caeruleaus for adding windowsbuild support
- vladimir for suggesting a different thread starting order
- fdb_ for suggesting SOAP in the first place

Add dummy effect of spell 51330
Restore compile Win32/x64 (VC80/VC90), add correct include dir to
all builds
Add dummy effect of spell 51333
Add dummy effect of spell 42287
Add dummy effect of spell 43036

Revert "[9465] Make passive aura buffs/debuffs always show at
not-casters."

This reverts commit 43f6a355e5a94c56c8fd6b881b572e1d685f046c.

Need more work.
Apply recent sql update to mangos.sql itself.

Mangos 9474 - 9501
Implement negative totem effect apply for 30706 and ranks.
Add and use TotemSlot enum type
Add basepoints array to Unit::HandleDummyAuraProc
Implement glyph 45776
Reimplement Aura::IsNeedVisibleSlot

Rewrite base at area aura type check
* For positive area aura types show at non-caster target or caster-totem
or non-passive aura at caster
* For negative area aura show at non-caster target
* For other auars show at any target if non passive auras or totem-caster
Use Clear call in MotionMaster::Initilize

Function can be called from deep code in time MotionMaster::Update.
So need use safe way cleanup with possible delayed movegens deletion.
Add aura dummy effect of spell 29266
Add dummy effect of spell 51276
Implement 48266, and 50365, 50384, 50391 and ranks.

Original patch provided by laise.
Not affect anything but not nice typos...
Add dummy aura effect of misc feign death spells

Please note that it may not be correct to handle them all in the same way.

Some more research should be done regarding the whole issue with creatures
and faking death (cheaters) and a possible difference between the spells.
Fix a value in movement update blocks with update flag
UPDATEFLAG_VEHICLE
Increase reserverd stack size for mangosd up to 4Mb at Windows

Most Unuxe/Linux OSs have by default 4Mb as max stack size for application
by default.
VisualStudio for x86/x64 set 1Mb by default. In result at Windows possible
more often
stack overflow crashes in cases when Unux version work fine. So we fix
this not nice
difference.

VS10 version not included. If someone prepare patch for VS10 case it can
be added to repo.
Fix a typo in Pet::addSpell
Fixed semaphore locking on non-posix systems
No reason have different code for apply/remove for this spells.
Make common apply/remove handler for another spell group in
HandleAuraDummy
Restore code commenting style after 9489/9490

Adjust comment style for rest of function and some additional code style
cleanup.
Some cleanup in effects table.
Fixed wrong spell cast at talent 50391 and ranks apply case.
Implement SPELL_EFFECT_JUMP (41).
Show overheal from HoT in combat log.
HomeBind fixes.

* Use area id instead zone id for home bind zone info as expected.
This will for example proper show capital name in area himebinding for
capital; tavern.
* Clarify that player create zone in fact is area (subzone)
* Implement SPELL_EFFECT_BIND for normal homebinding.
Also support spell target position mode used in 53823/53821 spells
* Add Spell::EffectEmpty for mark spell effects that used but not expect
any code in handler.
Example weapon spells that used just as known spell markers for client.

Original patch idea inspirit by Sadikum patch suggestion.
Implement basic use of SPLINETYPE_FACINGTARGET

Adjust related helper function accordingly.
Restored build on *nix
Add replacement spells for GO type 10 that may have dummy spellId
in _template
Update SpellCastResult enum to 3.3.x state.
More speel effects table cleanups in comments
Implement item limit category inventory mode.

* Now expected item limit categories (for example for item 5513 and
related)
correctly limited by its amount in inventory.
* Provide and use additional arg in SendEquipError for alt. way get
affected
item prototype. This let send to function item id and prevent crash
client at
limit category equip errors that required item prototype data.

Mangos 9502 - 9541
Update SpellCastResult enum to 3.3.x state.
Updated behavior of auto shot according to the client changes.
Removed obsolete code for spell 18096 and ranks.
Removed facing limitation for spell 2764.
Add missing AI calls to inform summoner of summon-related events



Implement SPELL_EFFECT_RESTORE_ITEM_CHARGES

Also it application in special case of item 5513 and similar.
Finish impement new functionlity for item 5513 and similar.

* Implement recharge low rank item in inventory.
* Implement recharge item at loading after 15 offline mins
Move custom data from item spell charges sign to new field
`NoConsumable`.

Some items with negative by defaul charges not expected to be deletedt at
no charges.
In past this fixed by using positive charges amount in like cases in
different from
expected negative value. Adding new field for avoid this.



Gameobject casting improvements.

* Add IsHostileTo/IsFriendlyTo and implement expected way checks for diff.
world object types.
For controlled object check redirected to specific owner, for wild
gameobject base at gameobject faction.
If faction not set expected to be hostile to anyone.
* Update grid searchers to be usable with world object instead only unit
case.
Some grid searches lost redundent second object arg,
AnyAoETargetUnitInObjectRangeCheck lost hitHidden arg
(for hitHidden==true case added new
AnyAoEVisibleTargetUnitInObjectRangeCheck)
* Updated grid searchers used with gameobject area casts now.
Note: Gameobject area spell cast animation will still wrong show around
cast triggering target instead
center around gameobject.
* In case gameobject aura apply to target for restored use target itself
as caster because
we not have currently another way apply aura form wild gameobject.
Hotfix for low chance crash at not accessable gameobject cast.
Spell 16952 and ranks will now correctly proc from all cat form
abilities that add combo points
Fix spell 48920
Implement opcode CMSG_HEARTH_AND_RESURRECT
Fix a possible exploit in CMSG_HEARTH_AND_RESURRECT
Fixed talent 50391 and ranks in part apply rune cooldown expire
speed.

* Apply rune cooldown buff only for spell 48265
* Implement SPELL_AURA_MOD_POWER_REGEN_PERCENT work for POWER_RUNE

Thanks to Laise for problem research.
rewrote RA console using ACE

- moved SQL pinging to SqlDelayThread
- use sAccountMgr instead of explict sql queries
Implement account associated execute for RA commands

* Now at login by RA-connection RA-connection use account id/access level
for commands execute. So at login with moderator access by RA-connection
you
can execute only moderator level commands. For administrator level
accounts
allowed execute only console level commands if new config option
RA.Stricted = 0.
For security reasons by default RA.Stricted = 1.
* RA-connection executed commands now logged for associalted account id
* Some own account related commands allowed execute in RA-connection

NOTE: config version updated because RA.Stricted = 1 not compatible with
old
way work and this can break tools thta use RA-access if it not
disabled.
Yuo will need update mangosd.conf.
Remove linking mangosd with sockets library.

Recent RA reimplementation added by Arrai remove using sockets library for
last part mangosd code.
This let not link anymore sockets library with mangosd.

Now realmd is last sockets library user.
Prevent possible memory leak in WorldSession
Let build map extractor at Mac OSX

Also restore build at Windows (Win32 not have unistd.h)

Win32 ad.exe binary updated but not expected any functional differences.
Implement spells 58600 and 58601
Stacking Auras from dual wild weapons.
Use cooldown data from gameobejct trap tamplate if provided.
Implement effect SPELL_EFFECT_TEACH_TAXI_NODE(154)

Original patch writed by Sadikum.
Fix a typo from commit 9512
Fix CRLF in 9512_01_mangos_spell_proc_event.sql.
Avoid apply spell bonuses to glyph 42397 effect.
Make Player::IsValidPos const
Fixed check for SPELL_AURA_ALLOW_ONLY_ABILITY

Also remove public access to SpellAura::m_spellmod for avoid another hacks

with it use. Spellmods only for Player::ApplySpellMod use.
Fixed apply stamina part of 48263
Fix typo in opcode name.
Use selected target for target mode 38/46 when provided.

For cases where provided target is not valid (or not provided), normal
closest in range will be used.
Attack Power bonus for spell 64382.
Some percent target max health spells.

Thanks to timmit for research.
Implement item 46017 effect.
Avoid proc item 46017 effect from DoTs.
Implement proper work spells 59465 and 56151.
Item 23836 effect and spell 54757 not affcted caster spell power.
Implement cooldown reset part for spell 60970 work.
Implement first target of spell 1064 and ranks boost from 61301.



YTDB 292

+ All fixes from forum;
+ spawn;
+ quest scripts;
+ mob's gossip menues;
+ new templates from WDB;
+ fix respawn ores/viens - Outland/Northrend
+ fix data in "achievement_criteria_requirement"
+ processed 150 caches (3.3.2);

Once again, thank you DjAligator .